Refactor Metadata.toXContent by extracting methods #124689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method is long and has two distinct paths for multi-project and single-project formats. This PR extracts separate method for each of the code paths for readability. See also: elastic#124613 (comment)
ywangd
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
nielsbauman
approved these changes
Mar 13, 2025
|
|
||
| // need to combine reserved state together into a single block so we don't get duplicate keys | ||
| // and not include it in the project xcontent output (through the lack of multi-project params) | ||
| // use a tree map so the order is deterministic |
There was a problem hiding this comment.
We don't need the tree map in the MP version?
There was a problem hiding this comment.
I actually have no idea. This is existing code. I thought the order was relied on tests. But I could not find any evidence.
pxsalehi
approved these changes
Mar 13, 2025
|
@elasticmachine update branch |
ywangd
added
the
auto-merge-without-approval
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
The method is long and has two distinct paths for multi-project and single-project formats. This PR extracts separate method for each of the code paths for readability. See also: elastic#124613 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is long and has two distinct paths for multi-project and single-project formats. This PR extracts separate method for each of the code paths for readability.
See also:
#124613 (comment)