-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return unique deprecation for old indices with incompatible date formats #124597
Merged
mark-vieira
merged 7 commits into
elastic:8.18
from
mark-vieira:old-index-incompatible-date-formats
Mar 18, 2025
Merged
Return unique deprecation for old indices with incompatible date formats #124597
mark-vieira
merged 7 commits into
elastic:8.18
from
mark-vieira:old-index-incompatible-date-formats
Mar 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecker.java
Hi @mark-vieira, I've created a changelog YAML for you. |
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Mar 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but one suggestion on the wording.
...n/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecker.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Core/Infra/Core
Core issues without another label
>enhancement
Team:Core/Infra
Meta label for core/infra team
v8.18.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indicies created with Elasticsearch 7.x will need to be reindexed for Elasticsearch 9.x. For indicies with field mappings containing incompatible date format patterns, this can result in an error. We should return a unique deprecation issue here so that the upgrade assistant in Kibana and inform users of this and link to appropriate documentation for remediation.
Relates to elastic/kibana#205289