Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return unique deprecation for old indices with incompatible date formats #124597

Merged

Conversation

mark-vieira
Copy link
Contributor

@mark-vieira mark-vieira commented Mar 11, 2025

Indicies created with Elasticsearch 7.x will need to be reindexed for Elasticsearch 9.x. For indicies with field mappings containing incompatible date format patterns, this can result in an error. We should return a unique deprecation issue here so that the upgrade assistant in Kibana and inform users of this and link to appropriate documentation for remediation.

Relates to elastic/kibana#205289

@mark-vieira mark-vieira changed the base branch from main to 8.18 March 11, 2025 20:40
elasticsearchmachine and others added 3 commits March 11, 2025 20:49
# Conflicts:
#	x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecker.java
@mark-vieira mark-vieira changed the title Old index incompatible date formats Return unique deprecation for old indices with incompatible date formats Mar 17, 2025
@mark-vieira mark-vieira added >enhancement :Core/Infra/Core Core issues without another label labels Mar 17, 2025
@mark-vieira mark-vieira requested a review from rjernst March 17, 2025 17:23
@elasticsearchmachine
Copy link
Collaborator

Hi @mark-vieira, I've created a changelog YAML for you.

@mark-vieira
Copy link
Contributor Author

This now looks like the following in the upgrade assistant.

Screenshot 2025-03-17 at 10 24 25 AM

@mark-vieira mark-vieira marked this pull request as ready for review March 17, 2025 17:25
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Mar 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but one suggestion on the wording.

@mark-vieira mark-vieira enabled auto-merge (squash) March 18, 2025 20:35
@mark-vieira mark-vieira merged commit e5ad498 into elastic:8.18 Mar 18, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >enhancement Team:Core/Infra Meta label for core/infra team v8.18.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants