Refactor data stream lifecycle to use the template paradigm #124593
Conversation
gmarouli
added
>refactoring
:Data Management/Data streams
gmarouli
added
auto-backport
elasticsearchmachine
added
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
I will work on the CI in the meantime, but I wanted to open it already for a review because it's quite a big. |
| } | ||
|
|
||
| private final boolean enabled; |
There was a problem hiding this comment.
I have been going back and forth about this one, should we keep it boolean or should we convert it to Boolean.
When it comes to failure store we had a specific use case where we enable it via a cluster setting. Here, we do not have such a use case yet, so I am leaning towards keep it as is. Any thoughts?
cc @dakrone
There was a problem hiding this comment.
I think keeping it as is until we have a more concrete need for it to change is probably the best approach here.
elasticsearchmachine
added
the
serverless-linked
| || out.getTransportVersion().isPatchFrom(TransportVersions.INTRODUCE_LIFECYCLE_TEMPLATE_8_19)) { | ||
| out.writeOptionalTimeValue(dataRetention); | ||
| } else { | ||
| out.writeBoolean(dataRetention != null); |
There was a problem hiding this comment.
You were right, this is indeed somewhat confusing. I understand that we're replicating writing an optional object that was writing an optional field of its own. Maybe we should add some comments to this method to mirror those added in the read method.
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…124593) (cherry picked from commit ce04da7) # Conflicts: # modules/data-streams/src/main/java/org/elasticsearch/datastreams/lifecycle/action/TransportGetDataStreamLifecycleStatsAction.java # modules/data-streams/src/test/java/org/elasticsearch/datastreams/MetadataIndexTemplateServiceTests.java # modules/data-streams/src/test/java/org/elasticsearch/datastreams/lifecycle/DataStreamLifecycleFixtures.java # server/src/main/java/org/elasticsearch/TransportVersions.java # server/src/main/java/org/elasticsearch/action/admin/indices/template/post/TransportSimulateIndexTemplateAction.java # server/src/main/java/org/elasticsearch/cluster/metadata/MetadataCreateDataStreamService.java # server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java # server/src/main/java/org/elasticsearch/cluster/metadata/ProjectMetadata.java # server/src/test/java/org/elasticsearch/cluster/metadata/DataStreamTests.java # server/src/test/java/org/elasticsearch/cluster/metadata/MetadataDataStreamsServiceTests.java # server/src/test/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateServiceTests.java
In this PR we migrate the
DataStreamLifecycleconfiguration to the new "template" framework we introduced in #117357. Effectively, we split the code that is used by the data stream and the templates. This is better for the following reasons:ResettableValueand can be composed easier as well.