Remove search throttled index setting and thread pool #124519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
v9.0.0
>refactoring
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
javanna
added
the
auto-backport
drempapis
reviewed
Mar 14, 2025
| @@ -184,12 +183,4 @@ protected ShardIterator shards(ProjectState state, InternalRequest request) { | |||
| return clusterService.operationRouting() | |||
| .getShards(state, request.concreteIndex(), request.request().id(), request.request().routing(), request.request().preference()); | |||
| } | |||
|
|
|||
| @Override | |||
| protected Executor getExecutor(ExplainRequest request, ShardId shardId) { | |||
There was a problem hiding this comment.
The request is not used in the parent class or subclasses.
There was a problem hiding this comment.
interesting catch, yes, that may mean we can refactor this further perhaps and remove the request argument, not too sure why it's there in the first place.
💔 Backport failed
You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frozen indices, the freeze index API and the private index.frozen setting have been removed with #120539.
There is also a search throttled thread pool that can now be removed, as well as a private
search.throttledindex settings that is no longer used as it could only be set internally by freezing an index.While the index setting is private and can be removed, as it should no longer be present in any index on 9.0+ indices, the thread pool settings associated to the removed pool are still accepted as no-op in case users have customized them and are upgrading without removing these. These will also trigger a deprecating warning.
This change also removes the
search.throttledrelated output from the thread pool section of the cluster info API.