[Profiling] Fix NullPointerExceptions by accepting dotted field names #124506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiling uses synthetic source and thus expects nested field names in query responses. With 8.17+, synthetic source is available only to Enterprise (or higher) subscriptions, so that smaller subscriptions have dotted field names in query responses. The profiling plugin relies on nested field names and runs into NullPointerExceptions if these are not found. This PR fixes the NullPointerExceptions that could happen with dotted field names. Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co>
rockdaboot
added
>bug
:UniversalProfiling/Application
elasticsearchmachine
added
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
christos68k
approved these changes
Mar 10, 2025
rockdaboot
added a commit
to rockdaboot/elasticsearch
that referenced
this pull request
Mar 12, 2025
…elastic#124506) * [Profiling] Fix NullPointerExceptions by accepting dotted field names Profiling uses synthetic source and thus expects nested field names in query responses. With 8.17+, synthetic source is available only to Enterprise (or higher) subscriptions, so that smaller subscriptions have dotted field names in query responses. The profiling plugin relies on nested field names and runs into NullPointerExceptions if these are not found. This PR fixes the NullPointerExceptions that could happen with dotted field names. Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co> * Evaluate source only once (cleanup) --------- Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co>
rockdaboot
added a commit
to rockdaboot/elasticsearch
that referenced
this pull request
Mar 12, 2025
…elastic#124506) * [Profiling] Fix NullPointerExceptions by accepting dotted field names Profiling uses synthetic source and thus expects nested field names in query responses. With 8.17+, synthetic source is available only to Enterprise (or higher) subscriptions, so that smaller subscriptions have dotted field names in query responses. The profiling plugin relies on nested field names and runs into NullPointerExceptions if these are not found. This PR fixes the NullPointerExceptions that could happen with dotted field names. Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co> * Evaluate source only once (cleanup) --------- Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co>
rockdaboot
added a commit
to rockdaboot/elasticsearch
that referenced
this pull request
Mar 12, 2025
…elastic#124506) * [Profiling] Fix NullPointerExceptions by accepting dotted field names Profiling uses synthetic source and thus expects nested field names in query responses. With 8.17+, synthetic source is available only to Enterprise (or higher) subscriptions, so that smaller subscriptions have dotted field names in query responses. The profiling plugin relies on nested field names and runs into NullPointerExceptions if these are not found. This PR fixes the NullPointerExceptions that could happen with dotted field names. Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co> * Evaluate source only once (cleanup) --------- Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co>
rockdaboot
added a commit
that referenced
this pull request
Mar 12, 2025
…#124506) (#124621) * [Profiling] Fix NullPointerExceptions by accepting dotted field names Profiling uses synthetic source and thus expects nested field names in query responses. With 8.17+, synthetic source is available only to Enterprise (or higher) subscriptions, so that smaller subscriptions have dotted field names in query responses. The profiling plugin relies on nested field names and runs into NullPointerExceptions if these are not found. This PR fixes the NullPointerExceptions that could happen with dotted field names. * Evaluate source only once (cleanup) --------- Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co>
rockdaboot
added a commit
that referenced
this pull request
Mar 12, 2025
…#124506) (#124622) * [Profiling] Fix NullPointerExceptions by accepting dotted field names Profiling uses synthetic source and thus expects nested field names in query responses. With 8.17+, synthetic source is available only to Enterprise (or higher) subscriptions, so that smaller subscriptions have dotted field names in query responses. The profiling plugin relies on nested field names and runs into NullPointerExceptions if these are not found. This PR fixes the NullPointerExceptions that could happen with dotted field names. * Evaluate source only once (cleanup) --------- Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co>
rockdaboot
added a commit
that referenced
this pull request
Mar 12, 2025
…#124506) (#124623) * [Profiling] Fix NullPointerExceptions by accepting dotted field names Profiling uses synthetic source and thus expects nested field names in query responses. With 8.17+, synthetic source is available only to Enterprise (or higher) subscriptions, so that smaller subscriptions have dotted field names in query responses. The profiling plugin relies on nested field names and runs into NullPointerExceptions if these are not found. This PR fixes the NullPointerExceptions that could happen with dotted field names. * Evaluate source only once (cleanup) --------- Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co>
rockdaboot
added a commit
that referenced
this pull request
Mar 12, 2025
…#124506) (#124624) * [Profiling] Fix NullPointerExceptions by accepting dotted field names Profiling uses synthetic source and thus expects nested field names in query responses. With 8.17+, synthetic source is available only to Enterprise (or higher) subscriptions, so that smaller subscriptions have dotted field names in query responses. The profiling plugin relies on nested field names and runs into NullPointerExceptions if these are not found. This PR fixes the NullPointerExceptions that could happen with dotted field names. * Evaluate source only once (cleanup) --------- Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co>
albertzaharovits
pushed a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Mar 13, 2025
…elastic#124506) * [Profiling] Fix NullPointerExceptions by accepting dotted field names Profiling uses synthetic source and thus expects nested field names in query responses. With 8.17+, synthetic source is available only to Enterprise (or higher) subscriptions, so that smaller subscriptions have dotted field names in query responses. The profiling plugin relies on nested field names and runs into NullPointerExceptions if these are not found. This PR fixes the NullPointerExceptions that could happen with dotted field names. Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co> * Evaluate source only once (cleanup) --------- Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co>
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
…elastic#124506) * [Profiling] Fix NullPointerExceptions by accepting dotted field names Profiling uses synthetic source and thus expects nested field names in query responses. With 8.17+, synthetic source is available only to Enterprise (or higher) subscriptions, so that smaller subscriptions have dotted field names in query responses. The profiling plugin relies on nested field names and runs into NullPointerExceptions if these are not found. This PR fixes the NullPointerExceptions that could happen with dotted field names. Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co> * Evaluate source only once (cleanup) --------- Signed-off-by: Tim Rühsen <tim.ruhsen@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling uses synthetic source and thus expects nested field names in query responses. With 8.17+, synthetic source is available only to Enterprise (or higher) subscriptions, so that smaller subscriptions have dotted field names in query responses. The profiling plugin relies on nested field names and runs into NullPointerExceptions if these are not found.
This PR fixes the NullPointerExceptions that could happen with dotted field names.