Fix FileAccessTreeTests#testDuplicateExclusivePaths to work on windows #124430
Conversation
ldematte
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
This change seems super subtle. I can't see a difference in the behaviour; how does this fix the tests? |
| @@ -447,7 +447,9 @@ public void testDuplicateEntitlements() { | |||
| public void testFilesEntitlementsWithExclusive() { | |||
| var baseTestPath = Path.of("/base").toAbsolutePath(); | |||
| var testPath1 = Path.of("/base/test").toAbsolutePath(); | |||
| var testPath1String = testPath1.toString(); | |||
There was a problem hiding this comment.
I thought these toString calls are not needed if the Strings.format call is using %s?
By forcing the same string Failure was: expected "Path [/a/b] ..." found "Path [C:\a\b] ... " on windows. |
|
Actually you are right, the second one is a red herring, it was not the same issue and it's fixed by Ryan's PR. I'll remove it. |
| ); | ||
| var iae = expectThrows(IllegalArgumentException.class, () -> buildExclusivePathList(distinctEntitlements, TEST_PATH_LOOKUP)); | ||
| var pathABString = pathAB.toAbsolutePath().toString(); |
There was a problem hiding this comment.
Oh the fix is this toAbsolutePath() call?
…stDuplicateExclusivePaths
….com:ldematte/elasticsearch into entitlements/fix-testDuplicateExclusivePaths
💔 Backport failed
You can use sqren/backport to manually backport by running |
|
Backports need #123676 |
Fix PolicyManagerTests#testFilesEntitlementsWithExclusive
Fixes #124437