Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Modify test case to update running job #124287

Merged
merged 6 commits into from
Mar 10, 2025

Conversation

edsavage
Copy link
Contributor

@edsavage edsavage commented Mar 7, 2025

This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821

This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
@edsavage edsavage added >test Issues or PRs that are addressing/adding tests :ml Machine learning v9.1.0 labels Mar 7, 2025
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Mar 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
@jonathan-buttner
Copy link
Contributor

@edsavage should we label this for 8.19 as well? Any reason not to backport the fix?

@edsavage
Copy link
Contributor Author

@edsavage should we label this for 8.19 as well? Any reason not to backport the fix?

Thanks Jonathan. Yes, this should be backported to at least 8.19 - maybe further (I'll check the release schedule to see what's appropriate)

@edsavage edsavage added v9.0.0 v8.18.0 v8.19.0 v8.16.6 v8.17.4 auto-backport Automatically create backport pull requests when merged labels Mar 10, 2025
@edsavage edsavage merged commit 376aad0 into elastic:main Mar 10, 2025
17 checks passed
edsavage added a commit to edsavage/elasticsearch that referenced this pull request Mar 10, 2025
This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.0
8.18
8.x
8.16
8.17

edsavage added a commit to edsavage/elasticsearch that referenced this pull request Mar 10, 2025
This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
edsavage added a commit to edsavage/elasticsearch that referenced this pull request Mar 10, 2025
This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
edsavage added a commit to edsavage/elasticsearch that referenced this pull request Mar 10, 2025
This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
edsavage added a commit to edsavage/elasticsearch that referenced this pull request Mar 10, 2025
This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
elasticsearchmachine pushed a commit that referenced this pull request Mar 10, 2025
This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
elasticsearchmachine pushed a commit that referenced this pull request Mar 10, 2025
This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
elasticsearchmachine pushed a commit that referenced this pull request Mar 10, 2025
This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
elasticsearchmachine pushed a commit that referenced this pull request Mar 10, 2025
This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
elasticsearchmachine pushed a commit that referenced this pull request Mar 10, 2025
This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
albertzaharovits pushed a commit to albertzaharovits/elasticsearch that referenced this pull request Mar 13, 2025
This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Mar 13, 2025
This PR makes a change to the existing Java REST test DetectionRulesIT.testCondition such that it updates detection rules for a running job. Previously it had relied on closing and re-opening the job for the update to take effect.

Relates elastic/ml-cpp#2821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.16.6 v8.17.4 v8.18.0 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants