Limit the log line length for s3 deletion error #123953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If all items fail to delete, the current warning log builds a huge string to include all of them (up to 1000). This PR limits the string to a length of 1000 characters. Relates: elastic#123630
ywangd
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
pxsalehi
reviewed
Mar 4, 2025
| () -> format( | ||
| "Failed to delete some blobs %s", | ||
| e.getErrors() | ||
| logger.warn(() -> { |
There was a problem hiding this comment.
I guess it makes sense to not spit out all of the blob names. But two nits: could we instead just pick the first N items rather than truncating it like this? Also since this is a WARN for an error case, having the runnable for the logger isn't really helping much, just makes it harder to read, IMO. Can we pull that out?
There was a problem hiding this comment.
Pushe 5d67feb which should address both suggestions. Thanks!
There was a problem hiding this comment.
Btw the usage of Strings.collectionToDelimitedStringWithLimit was modelled after this. It might be worthwhile to extract a new common method for both as well.
pxsalehi
approved these changes
Mar 5, 2025
ywangd
added
auto-backport
|
@elasticmachine update branch |
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Mar 6, 2025
If all items fail to delete, the current warning log builds a huge string to include all of them (up to 1000). This PR limits the string length to first 10 entries. Relates: elastic#123630 (cherry picked from commit a9432ba) # Conflicts: # modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java # modules/repository-s3/src/test/java/org/elasticsearch/repositories/s3/S3BlobContainerRetriesTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 6, 2025
) * Limit the log line length for s3 deletion error (#123953) If all items fail to delete, the current warning log builds a huge string to include all of them (up to 1000). This PR limits the string length to first 10 entries. Relates: #123630 (cherry picked from commit a9432ba) # Conflicts: # modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java # modules/repository-s3/src/test/java/org/elasticsearch/repositories/s3/S3BlobContainerRetriesTests.java * fix backport
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
If all items fail to delete, the current warning log builds a huge string to include all of them (up to 1000). This PR limits the string length to first 10 entries. Relates: elastic#123630
costin
pushed a commit
to costin/elasticsearch
that referenced
this pull request
Mar 15, 2025
If all items fail to delete, the current warning log builds a huge string to include all of them (up to 1000). This PR limits the string length to first 10 entries. Relates: elastic#123630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all items fail to delete, the current warning log builds a huge string to include all of them (up to 1000). This PR limits the string length to first 10 entries.
Relates: #123630