Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant read access to the config dir #123882

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Mar 3, 2025

This matches what Security Manager permissions Elasticsearch had for all plugins.

This matches what Security Manager permissions Elasticsearch had for all
plugins.
@rjernst rjernst added >refactoring auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Mar 3, 2025
@rjernst rjernst requested a review from a team as a code owner March 3, 2025 14:33
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Mar 3, 2025
Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

addPathAndMaybeLink.accept(pathLookup.tempDir(), Mode.READ_WRITE);
addPathAndMaybeLink.accept(pathLookup.configDir(), Mode.READ);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want this to be permanent, or a stop-gap solution until we figure out the policy files?
If it's the latter, can you add a TODO comment please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rjernst rjernst enabled auto-merge (squash) March 3, 2025 18:36
@rjernst rjernst merged commit 4841f43 into elastic:main Mar 3, 2025
16 of 17 checks passed
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Mar 3, 2025
This matches what Security Manager permissions Elasticsearch had for all
plugins.
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Mar 3, 2025
This matches what Security Manager permissions Elasticsearch had for all
plugins.
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Mar 3, 2025
This matches what Security Manager permissions Elasticsearch had for all
plugins.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.18
8.x
9.0

elasticsearchmachine pushed a commit that referenced this pull request Mar 3, 2025
This matches what Security Manager permissions Elasticsearch had for all
plugins.
elasticsearchmachine pushed a commit that referenced this pull request Mar 3, 2025
This matches what Security Manager permissions Elasticsearch had for all
plugins.
elasticsearchmachine pushed a commit that referenced this pull request Mar 4, 2025
This matches what Security Manager permissions Elasticsearch had for all
plugins.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
This matches what Security Manager permissions Elasticsearch had for all
plugins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >refactoring Team:Core/Infra Meta label for core/infra team v8.18.1 v8.19.0 v9.0.1 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants