Use valid REST version when determining capabilities #123864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
added
:Core/Infra/REST API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
So, this uses a cluster feature to determine when we should use v8 vs v9 api version by default, and doesn't need any changes on 8.x lines. |
|
This could be made more generic by using |
rjernst
reviewed
Mar 5, 2025
server/src/main/java/org/elasticsearch/features/InfrastructureFeatures.java
Outdated
Show resolved
Hide resolved
...g/elasticsearch/action/admin/cluster/node/capabilities/TransportNodesCapabilitiesAction.java
Outdated
Show resolved
Hide resolved
...g/elasticsearch/action/admin/cluster/node/capabilities/TransportNodesCapabilitiesAction.java
Outdated
Show resolved
Hide resolved
thecoop
force-pushed
the
rest-v9-capabilities
branch
from
3758cbb to
1e9ec42
Compare
thecoop
added
the
auto-backport
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Mar 7, 2025
If the rest api version is not specified, infer the correct one to use from the major versions present on the cluster, determined using features
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 7, 2025
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
If the rest api version is not specified, infer the correct one to use from the major versions present on the cluster, determined using features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8 nodes don't know about v9 REST API. But when doing a capabilities check, with implicit rest version, you just want to know what the current cluster can do. So this does that.