Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit import layout for packages begin with io #123854

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Mar 3, 2025

This PR adds explicit import layout for io.* packages so that their import orders are consistent between IDE and CLI. Without it, the IDE places the io.* imports at the bottom of the import list. See AbstractRepositoryS3RestTestCase for such an example.

This PR adds explicit import layout for io.* packages so that their
import orders are consistent between IDE and CLI. Without it, the IDE
places the io.* imports at the bottom of the import list.
See AbstractRepositoryS3RestTestCase for such an example.
@ywangd ywangd added >non-issue :Delivery/Tooling Developer tooliing and automation v9.1.0 labels Mar 3, 2025
@ywangd ywangd requested review from breskeby and mark-vieira March 3, 2025 08:43
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticsearchmachine elasticsearchmachine added the Team:Delivery Meta label for Delivery team label Mar 3, 2025
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd ywangd merged commit 9431c67 into elastic:main Mar 3, 2025
17 checks passed
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
This PR adds explicit import layout for io.* packages so that their
import orders are consistent between IDE and CLI. Without it, the IDE
places the io.* imports at the bottom of the import list.
See AbstractRepositoryS3RestTestCase for such an example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Tooling Developer tooliing and automation >non-issue Team:Delivery Meta label for Delivery team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants