Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust exception thrown when unable to load hunspell dict #123743

Conversation

benwtrent
Copy link
Member

On index creation, its possible to configure an hunspell analyzer, but reference a locale file that actually doesn't exist or isn't accessible.

This error, like our other user dictionary errors, should be an IAE not an ISE.

closes: #123729

@benwtrent benwtrent added >bug :Search Relevance/Analysis How text is split into tokens auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 labels Feb 28, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Feb 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @benwtrent, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

…enwtrent/elasticsearch into bugfix/fix-hunspell-dict-loading-error
@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Feb 28, 2025
benwtrent and others added 4 commits February 28, 2025 15:46

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Mar 5, 2025
@elasticsearchmachine elasticsearchmachine merged commit a92b1d6 into elastic:main Mar 5, 2025
18 checks passed
@benwtrent benwtrent deleted the bugfix/fix-hunspell-dict-loading-error branch March 5, 2025 19:19
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.18 Commit could not be cherrypicked due to conflicts
8.x Commit could not be cherrypicked due to conflicts
9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 123743

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Mar 5, 2025
…3743)

On index creation, its possible to configure an hunspell analyzer, but
reference a locale file that actually doesn't exist or isn't accessible.

This error, like our other user dictionary errors, should be an IAE not
an ISE.

closes: elastic#123729
(cherry picked from commit a92b1d6)
@benwtrent
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.x
9.0
8.18

Questions ?

Please refer to the Backport tool documentation

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Mar 5, 2025
…3743)

On index creation, its possible to configure an hunspell analyzer, but
reference a locale file that actually doesn't exist or isn't accessible.

This error, like our other user dictionary errors, should be an IAE not
an ISE.

closes: elastic#123729
(cherry picked from commit a92b1d6)
elasticsearchmachine pushed a commit that referenced this pull request Mar 5, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…124146)

On index creation, its possible to configure an hunspell analyzer, but
reference a locale file that actually doesn't exist or isn't accessible.

This error, like our other user dictionary errors, should be an IAE not
an ISE.

closes: #123729
(cherry picked from commit a92b1d6)
elasticsearchmachine pushed a commit that referenced this pull request Mar 6, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…124143)

On index creation, its possible to configure an hunspell analyzer, but
reference a locale file that actually doesn't exist or isn't accessible.

This error, like our other user dictionary errors, should be an IAE not
an ISE.

closes: #123729
(cherry picked from commit a92b1d6)
elasticsearchmachine pushed a commit that referenced this pull request Mar 6, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…124142)

On index creation, its possible to configure an hunspell analyzer, but
reference a locale file that actually doesn't exist or isn't accessible.

This error, like our other user dictionary errors, should be an IAE not
an ISE.

closes: #123729
(cherry picked from commit a92b1d6)
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025

Verified

This commit was signed with the committer’s verified signature.
georgewallace George Wallace
…3743)

On index creation, its possible to configure an hunspell analyzer, but
reference a locale file that actually doesn't exist or isn't accessible.

This error, like our other user dictionary errors, should be an IAE not
an ISE.

closes: elastic#123729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Search Relevance/Analysis How text is split into tokens serverless-linked Added by automation, don't add manually Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.18.1 v8.19.0 v9.0.1 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index creation requests should return 400 on analyzer dictionary missing
3 participants