[8.x] Add deprecation warning to TransportHandshaker (#123188) #123627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a deprecation warning log to the TransportHandshaker when connecting with nodes < v8.18.
JVerwolf
added
:Core/Infra/Core
DaveCTurner
removed
the
auto-merge-without-approval
|
I think the situation in 8.19 is a little different - after upgrading to 8.19 you can't go to 9.0, only 9.1, and 9.1 will reject connections from 8.18-and-earlier. I've removed the auto-merge label here while we address that. |
JVerwolf
commented
Feb 27, 2025
| will not be supported from version 9.1.0 onwards. You must upgrade all your clusters to version 8.19.0 or later | ||
| before upgrading any of your clusters to 9.1.0 or later. | ||
| impact: > | ||
| Upgrade all of your clusters to at least 8.19.0 before upgrading any of them to 9.1.0 or later. |
There was a problem hiding this comment.
I updated the release notes to reference 8.19 and 9.1
JVerwolf
commented
Feb 27, 2025
| @@ -171,6 +176,7 @@ final class TransportHandshaker { | |||
| ); | |||
|
|
|||
| static final String HANDSHAKE_ACTION_NAME = "internal:tcp/handshake"; | |||
| static final TransportVersion V8_19_FIRST_VERSION = TransportVersions.INITIAL_ELASTICSEARCH_8_19; | |||
There was a problem hiding this comment.
Double checking, Is this the first TV on 8.19?
JVerwolf
commented
Feb 27, 2025
| ) { | ||
| return Strings.format( | ||
| "Performed a handshake with a remote node with version [%s/%s] received on [%s] which " | ||
| + "will be incompatible after this node on version [%s/%s] is upgraded to >= 9.1.", |
There was a problem hiding this comment.
I changed this from 9.x. to >= 9.1.
rjernst
approved these changes
Mar 4, 2025
| communication within a cluster and communication across clusters (e.g. for <<modules-cross-cluster-search,{ccs}>> or | ||
| <<xpack-ccr,{ccr}>>). | ||
|
|
||
| {es} will report in its <<deprecation-logging, deprecation logging>> each time it opens a connection to a node that |
There was a problem hiding this comment.
nit: deprecation logging -> deprecation log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.x: