Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of 'getProject' in RoutingNodes #123567

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Feb 27, 2025

When #119968 was merged into multi-project we introduced a regression by inserting a call to .getProject() within the RoutingNodes class that was supposed to be multi-project-aware.

This commit replaces those calls with .indexMetadata lookups

When elastic#119968 was merged into multi-project we introduced a regression
by inserting a call to `.getProject()` within the `RoutingNodes` class
that was supposed to be multi-project-aware.

This commit replaces those calls with `.indexMetadata` lookups
@tvernum tvernum requested a review from ywangd February 27, 2025 02:38
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Feb 27, 2025
@tvernum tvernum added v9.1.0 :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >bug labels Feb 27, 2025
@elasticsearchmachine elasticsearchmachine added Team:Distributed Coordination Meta label for Distributed Coordination team and removed needs:triage Requires assignment of a team area label labels Feb 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvernum tvernum added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Feb 27, 2025
@elasticsearchmachine elasticsearchmachine merged commit 779e1ad into elastic:feature/multi-project Feb 27, 2025
16 checks passed
@tvernum tvernum deleted the multiproject/fix/RetryFailedAllocationTests branch February 27, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Coordination Meta label for Distributed Coordination team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants