Speedup SearchResponse serialization #123211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to have a nested concat here. There's obviously lots and lots of room for optimization on this one, but just flattening out one obvious step here outright halves the number of method calls required when serializing a search response. Given that method calls can consume up to half the serialization cost this change might massively speed up some usecases.
original-brownbear
added
>non-issue
:Search Foundations/Search
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
Team:Search Foundations
| return Iterators.concat( | ||
| wrapInObject ? ChunkedToXContentHelper.startObject() : Collections.emptyIterator(), |
There was a problem hiding this comment.
Very lazy solution admittedly here and for the end-object but it doesn't matter as the cost comes from the hits iterator anyway.
javanna
approved these changes
Feb 24, 2025
original-brownbear
added
auto-backport
|
Thanks Luca! |
💔 Backport failed
You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to have two nested concat iterators here (each of which adding a layer of megamorphic calls + pointer indirection on every
nextandhasNext()!!!). There's obviously still lots and lots of room for optimization on this one, but just flattening out two obvious steps here enormously reduces the number of method calls required when serializing a search response. Given that method calls can consume up to half the serialization cost this change might massively speed up some use cases.