Run TransportExplainLifecycleAction on local node
#122885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This action solely needs the cluster state, it can run on any node. Additionally, it needs to be cancellable to avoid doing unnecessary work after a client failure or timeout. Relates elastic#101805
nielsbauman
added
>enhancement
:Data Management/ILM+SLM
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @nielsbauman, I've created a changelog YAML for you. |
|
Related to #120982 |
nielsbauman
commented
Feb 18, 2025
| @@ -24,26 +31,58 @@ | |||
| * Multiple indices may be queried in the same request using the | |||
| * {@link #indices(String...)} method | |||
| */ | |||
| public class ExplainLifecycleRequest extends ClusterInfoRequest<ExplainLifecycleRequest> { | |||
| public class ExplainLifecycleRequest extends LocalClusterStateRequest implements IndicesRequest.Replaceable { | |||
There was a problem hiding this comment.
The ClusterInfo classes feel a bit off; the only value they add are specifying indices and indicesOptions, but loads of other actions specify those manually. Therefore, we might as well get rid of the ClusterInfo abstraction and let every class define by themselves what fields they have.
| // If this is requesting only errors, only include indices in the error step or which are using a nonexistent policy | ||
| if (onlyErrors == false | ||
| || (ErrorStep.NAME.equals(lifecycleState.step()) || indexLifecycleService.policyExists(policyName) == false)) { | ||
| if (onlyErrors == false || (ErrorStep.NAME.equals(lifecycleState.step()) || policyExists == false)) { |
There was a problem hiding this comment.
The IndexLifecycleService only runs on the master node, which meant that policyExists was always false. I changed it to use the Metadata to check for policy existence.
dakrone
requested changes
Mar 3, 2025
...in/ilm/src/main/java/org/elasticsearch/xpack/ilm/action/TransportExplainLifecycleAction.java
Outdated
Show resolved
Hide resolved
45 tasks
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
This action solely needs the cluster state, it can run on any node. Additionally, it needs to be cancellable to avoid doing unnecessary work after a client failure or timeout. Relates elastic#101805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action solely needs the cluster state, it can run on any node. Additionally, it needs to be cancellable to avoid doing unnecessary work after a client failure or timeout.
Relates #101805