Remove synthetic recovery source feature flag. #122615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>enhancement
:Distributed Indexing/Recovery
|
Hi @martijnvg, I've created a changelog YAML for you. |
elasticsearchmachine
added
Team:StorageEngine
Team:Distributed Indexing
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
…ecovery_source_feature_flag
…ecovery_source_feature_flag
…ecovery_source_feature_flag
|
Hi @martijnvg, I've updated the changelog YAML for you. |
kkrik-es
reviewed
Mar 5, 2025
| "es.index_recovery_use_synthetic_source_feature_flag_enabled=true", | ||
| Version.fromString("8.18.0"), | ||
| null | ||
| ), |
There was a problem hiding this comment.
Does this cause issues during upgrade?
There was a problem hiding this comment.
No, since the feature flag is now completely removed and so regular index version checks avoid issue during upgrades.
kkrik-es
approved these changes
Mar 5, 2025
martijnvg
added
v8.18.1
v9.0.1
auto-backport
…ecovery_source_feature_flag
💔 Backport failed
You can use sqren/backport to manually backport by running |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 5, 2025
Backporting elastic#122615 to 8.branch. This feature flag controls whether synthetic recovery source is enabled by default when the source mode is synthetic. The synthetic recovery source feature itself is already available via the index.recovery.use_synthetic_source index setting and can be enabled by anyone using synthetic source. The default value of index.recovery.use_synthetic_source setting defaults to true when index.mapping.source.mode is enabled. The index.mapping.source.mode default to true if index.mode is logsdb or time_series. In other words, with this change synthetic recovery source will be enabled by default for logsdb and tsdb. Closes elastic#116726
martijnvg
added a commit
that referenced
this pull request
Mar 6, 2025
Backporting #122615 to 8.branch. This feature flag controls whether synthetic recovery source is enabled by default when the source mode is synthetic. The synthetic recovery source feature itself is already available via the index.recovery.use_synthetic_source index setting and can be enabled by anyone using synthetic source. The default value of index.recovery.use_synthetic_source setting defaults to true when index.mapping.source.mode is enabled. The index.mapping.source.mode default to true if index.mode is logsdb or time_series. In other words, with this change synthetic recovery source will be enabled by default for logsdb and tsdb. Closes #116726
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
This feature flag controls whether synthetic recovery source is enabled by default when the source mode is synthetic. The synthetic recovery source feature itself is already available via the index.recovery.use_synthetic_source index setting and can be enabled by anyone using synthetic source. The default value of index.recovery.use_synthetic_source setting defaults to true when index.mapping.source.mode is enabled. The index.mapping.source.mode default to true if index.mode is logsdb or time_series. In other words, with this change synthetic recovery source will be enabled by default for logsdb and tsdb. Closes elastic#116726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature flag controls whether synthetic recovery source is enabled by default when the source mode is synthetic.
The synthetic recovery source feature itself is already available via the
index.recovery.use_synthetic_sourceindex setting and can be enabled by anyone using synthetic source.The default value of
index.recovery.use_synthetic_sourcesetting defaults to true whenindex.mapping.source.modeis enabled. Theindex.mapping.source.modedefault to true ifindex.modeislogsdbortime_series.In other words, with this change synthetic recovery source will be enabled by default for logsdb and tsdb.
Closes #116726