Fix a few toString implementations+usages that affect test performance #112380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to precompute the toString for `ActionListener` and `Releasable`, that's quite expensive at times. Also string concat is way faster than formating these days, so use that in the transport channels. Lastly, short-circuit some obvious spots in network address serialization and remove code that duplicates the JDK (remove the IPV4 specific forbidden API because it makes no sense, but still needed to disable the check to make the build green because of the exclude on the parent class).
original-brownbear
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
v8.16.0
Team:Core/Infra
jdconrad
approved these changes
Aug 29, 2024
prdoyle
reviewed
Aug 30, 2024
| @@ -246,14 +247,14 @@ public static String toUriString(InetAddress ip) { | |||
| * @return {@code String} containing the text-formatted IP address | |||
| * @since 10.0 | |||
| */ | |||
| @SuppressForbidden(reason = "java.net.Inet4Address#getHostAddress() is fine no need to duplicate its code") | |||
There was a problem hiding this comment.
The comment for this suggests "use NetworkAddress format() to print IP or IP+ports". Is that a better way to achieve this?
There was a problem hiding this comment.
Not sure, I think the problem is only with the ipv6 version of this method, but it seems impossible to selectively catch that only with forbidden apis?
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Aug 30, 2024
elastic#112380) No need to precompute the toString for `ActionListener` and `Releasable`, that's quite expensive at times. Also string concat is way faster than formating these days, so use that in the transport channels. Lastly, short-circuit some obvious spots in network address serialization and remove code that duplicates the JDK (remove the IPV4 specific forbidden API because it makes no sense, but still needed to disable the check to make the build green because of the exclude on the parent class).
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
elastic#112380) No need to precompute the toString for `ActionListener` and `Releasable`, that's quite expensive at times. Also string concat is way faster than formating these days, so use that in the transport channels. Lastly, short-circuit some obvious spots in network address serialization and remove code that duplicates the JDK (remove the IPV4 specific forbidden API because it makes no sense, but still needed to disable the check to make the build green because of the exclude on the parent class).
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 12, 2025
In elastic#112380 we changed this `assert` to yield a `String` on failure rather than the original `ElasticsearchException`, which means we don't see the original completion's stack trace any more. This commit reinstates the lost stack trace.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
In #112380 we changed this `assert` to yield a `String` on failure rather than the original `ElasticsearchException`, which means we don't see the original completion's stack trace any more. This commit reinstates the lost stack trace.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 13, 2025
In elastic#112380 we changed this `assert` to yield a `String` on failure rather than the original `ElasticsearchException`, which means we don't see the original completion's stack trace any more. This commit reinstates the lost stack trace.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 13, 2025
In elastic#112380 we changed this `assert` to yield a `String` on failure rather than the original `ElasticsearchException`, which means we don't see the original completion's stack trace any more. This commit reinstates the lost stack trace.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 13, 2025
In elastic#112380 we changed this `assert` to yield a `String` on failure rather than the original `ElasticsearchException`, which means we don't see the original completion's stack trace any more. This commit reinstates the lost stack trace.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 13, 2025
In elastic#112380 we changed this `assert` to yield a `String` on failure rather than the original `ElasticsearchException`, which means we don't see the original completion's stack trace any more. This commit reinstates the lost stack trace.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
In #112380 we changed this `assert` to yield a `String` on failure rather than the original `ElasticsearchException`, which means we don't see the original completion's stack trace any more. This commit reinstates the lost stack trace.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
In #112380 we changed this `assert` to yield a `String` on failure rather than the original `ElasticsearchException`, which means we don't see the original completion's stack trace any more. This commit reinstates the lost stack trace.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
In #112380 we changed this `assert` to yield a `String` on failure rather than the original `ElasticsearchException`, which means we don't see the original completion's stack trace any more. This commit reinstates the lost stack trace.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
In #112380 we changed this `assert` to yield a `String` on failure rather than the original `ElasticsearchException`, which means we don't see the original completion's stack trace any more. This commit reinstates the lost stack trace.
albertzaharovits
pushed a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Mar 13, 2025
In elastic#112380 we changed this `assert` to yield a `String` on failure rather than the original `ElasticsearchException`, which means we don't see the original completion's stack trace any more. This commit reinstates the lost stack trace.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
In elastic#112380 we changed this `assert` to yield a `String` on failure rather than the original `ElasticsearchException`, which means we don't see the original completion's stack trace any more. This commit reinstates the lost stack trace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to precompute the toString for
ActionListenerandReleasable, that's quite expensive at times (taking like 30s across all threads forserver:integTestCaseneedlessly). Also string concat is way faster than formating these days, so use that in the transport channels. Lastly, short-circuit some obvious spots in network address serialization and remove code that duplicates the JDK (remove the IPV4 specific forbidden API because it makes no sense, but still needed to disable the check to make the build green because of the exclude on the parent class).