Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partial results in ES|QL #122802

Open
4 of 9 tasks
dnhatn opened this issue Feb 17, 2025 · 2 comments
Open
4 of 9 tasks

Support partial results in ES|QL #122802

dnhatn opened this issue Feb 17, 2025 · 2 comments
Assignees
Labels
:Analytics/ES|QL AKA ESQL >enhancement Meta Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@dnhatn
Copy link
Member

dnhatn commented Feb 17, 2025

@dnhatn dnhatn self-assigned this Feb 17, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@bpintea
Copy link
Contributor

bpintea commented Feb 24, 2025

Related: #111518

dnhatn added a commit that referenced this issue Mar 5, 2025
This change introduces a cluster setting 
`esql.query.allow_partial_results` that allows enabling or disabling
allow_partial_results in ES|QL at the cluster-wide level. Initially,
this setting defaults to false, but it will be switched to true soon. 
The reason for not changing the default in this PR is that it requires
adjusting many tests, which would make the PR too large. Instead, we
will adjust the tests incrementally and switch the default when the
tests are ready. This cluster setting is useful for falling back to the
previous behavior (i.e., disabling allow_partial_results) if users
upgrade to the new version and haven't updated their queries.

Also, the default setting can be overridden on a per-request basis via a 
URL parameter (allow_partial_results) (changed from request body to URL
parameter to conform to the proposal).

Relates #122802
dnhatn added a commit to dnhatn/elasticsearch that referenced this issue Mar 5, 2025
This change introduces a cluster setting 
`esql.query.allow_partial_results` that allows enabling or disabling
allow_partial_results in ES|QL at the cluster-wide level. Initially,
this setting defaults to false, but it will be switched to true soon. 
The reason for not changing the default in this PR is that it requires
adjusting many tests, which would make the PR too large. Instead, we
will adjust the tests incrementally and switch the default when the
tests are ready. This cluster setting is useful for falling back to the
previous behavior (i.e., disabling allow_partial_results) if users
upgrade to the new version and haven't updated their queries.

Also, the default setting can be overridden on a per-request basis via a 
URL parameter (allow_partial_results) (changed from request body to URL
parameter to conform to the proposal).

Relates elastic#122802
elasticsearchmachine pushed a commit that referenced this issue Mar 5, 2025
This change introduces a cluster setting 
`esql.query.allow_partial_results` that allows enabling or disabling
allow_partial_results in ES|QL at the cluster-wide level. Initially,
this setting defaults to false, but it will be switched to true soon. 
The reason for not changing the default in this PR is that it requires
adjusting many tests, which would make the PR too large. Instead, we
will adjust the tests incrementally and switch the default when the
tests are ready. This cluster setting is useful for falling back to the
previous behavior (i.e., disabling allow_partial_results) if users
upgrade to the new version and haven't updated their queries.

Also, the default setting can be overridden on a per-request basis via a 
URL parameter (allow_partial_results) (changed from request body to URL
parameter to conform to the proposal).

Relates #122802
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this issue Mar 11, 2025
This change introduces a cluster setting 
`esql.query.allow_partial_results` that allows enabling or disabling
allow_partial_results in ES|QL at the cluster-wide level. Initially,
this setting defaults to false, but it will be switched to true soon. 
The reason for not changing the default in this PR is that it requires
adjusting many tests, which would make the PR too large. Instead, we
will adjust the tests incrementally and switch the default when the
tests are ready. This cluster setting is useful for falling back to the
previous behavior (i.e., disabling allow_partial_results) if users
upgrade to the new version and haven't updated their queries.

Also, the default setting can be overridden on a per-request basis via a 
URL parameter (allow_partial_results) (changed from request body to URL
parameter to conform to the proposal).

Relates elastic#122802
dnhatn added a commit that referenced this issue Mar 16, 2025
This change includes failures when ESQL returns partial results. It also 
carries failures between cluster requests.

Relates #122802
dnhatn added a commit to dnhatn/elasticsearch that referenced this issue Mar 17, 2025
This change includes failures when ESQL returns partial results. It also
carries failures between cluster requests.

Relates elastic#122802
dnhatn added a commit that referenced this issue Mar 17, 2025
This change includes failures when ESQL returns partial results. It also
carries failures between cluster requests.

Relates #122802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >enhancement Meta Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

3 participants