Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] ShapeGeometryFieldMapperTests testCartesianBoundsBlockLoader failing #122661

Closed
elasticsearchmachine opened this issue Feb 15, 2025 · 4 comments · Fixed by #122871
Closed

[CI] ShapeGeometryFieldMapperTests testCartesianBoundsBlockLoader failing #122661

elasticsearchmachine opened this issue Feb 15, 2025 · 4 comments · Fixed by #122871
Assignees
@GalLalouche
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 15, 2025 •
edited
Loading

Build Scans:

Reproduction Line:

./gradlew ":server:test" --tests "org.elasticsearch.index.mapper.ShapeGeometryFieldMapperTests.testCartesianBoundsBlockLoader" -Dtests.seed=BB0E51E39EFD3660 -Dtests.locale=ff-Latn-SN -Dtests.timezone=America/Kentucky/Louisville -Druntime.java=21 -Dtests.fips.enabled=true

Applicable branches:
9.0

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: geometry[0] 'BBOX (-5.3897702806159435E35, 4.170412018425846E35, 3.4028234346940236E35, -5.492458298191494E35)' wasn't extracted correctly
Expected: "    BBOX (-5.3897702806159435E35, 4.170412018425846E35, 3.4028234346940236E35, -5.492458298191494E35)"
     but: was <BBOX (-4.1557785768094616E35, -1.209586260625588E35, 1.4328447853025805E35, -1.6270996623167576E35)>

Issue Reasons:

  • [9.0] 3 failures in test testCartesianBoundsBlockLoader (1.2% fail rate in 249 executions)
  • [9.0] 2 failures in step part-1 (7.4% fail rate in 27 executions)
  • [9.0] 2 failures in pipeline elasticsearch-pull-request (7.7% fail rate in 26 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI labels Feb 15, 2025
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 2 failures in test testCartesianBoundsBlockLoader (0.3% fail rate in 670 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Feb 15, 2025
@elasticsearchmachine
Mute org.elasticsearch.index.mapper.ShapeGeometryFieldMapperTests tes…
ac72785 
…tCartesianBoundsBlockLoader #122661
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) needs:risk Requires assignment of a risk label (low, medium, blocker) labels Feb 15, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-analytical-engine (Team:Analytics)

@GalLalouche GalLalouche self-assigned this Feb 17, 2025
@GalLalouche GalLalouche added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Feb 17, 2025
@GalLalouche GalLalouche mentioned this issue Feb 18, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch 8.x

Mute Reasons:

  • [8.x] 2 failures in test testCartesianBoundsBlockLoader (0.6% fail rate in 343 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Feb 19, 2025
@elasticsearchmachine
Mute org.elasticsearch.index.mapper.ShapeGeometryFieldMapperTests tes…
08bf3b9 
…tCartesianBoundsBlockLoader #122661
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch 9.0

Mute Reasons:

  • [9.0] 3 failures in test testCartesianBoundsBlockLoader (1.2% fail rate in 249 executions)
  • [9.0] 2 failures in step part-1 (7.4% fail rate in 27 executions)
  • [9.0] 2 failures in pipeline elasticsearch-pull-request (7.7% fail rate in 26 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Mar 3, 2025
@elasticsearchmachine
Mute org.elasticsearch.index.mapper.ShapeGeometryFieldMapperTests tes…
273b244 
…tCartesianBoundsBlockLoader #122661
GalLalouche added a commit to GalLalouche/elasticsearch that referenced this issue Mar 6, 2025
@GalLalouche
ESQL: Fix ShapeGeometryFieldMapperTests (and rename) (elastic#122871)
360eb49 
Fixes elastic#122661.
The issue was caused by RandomIndexWriter (randomly) reshuffling the document writing order. Since this test also ensures that the documents are read in the input order, I've opted to use a regular IndexWriter instead. I've also renamed the class to AbstractShapeGeometryFieldMapperTests since it was originally renamed due to a misunderstanding of muted tests (which caused it to be muted again! Busted 😅).
GalLalouche added a commit to GalLalouche/elasticsearch that referenced this issue Mar 6, 2025
@GalLalouche
ESQL: Fix ShapeGeometryFieldMapperTests (and rename) (elastic#122871)
b4b4029 
Fixes elastic#122661.
The issue was caused by RandomIndexWriter (randomly) reshuffling the document writing order. Since this test also ensures that the documents are read in the input order, I've opted to use a regular IndexWriter instead. I've also renamed the class to AbstractShapeGeometryFieldMapperTests since it was originally renamed due to a misunderstanding of muted tests (which caused it to be muted again! Busted 😅).
elasticsearchmachine pushed a commit that referenced this issue Mar 6, 2025
@GalLalouche
ESQL: Fix ShapeGeometryFieldMapperTests (and rename) (#122871) (#124251)
cee80d4 
Fixes #122661.
The issue was caused by RandomIndexWriter (randomly) reshuffling the document writing order. Since this test also ensures that the documents are read in the input order, I've opted to use a regular IndexWriter instead. I've also renamed the class to AbstractShapeGeometryFieldMapperTests since it was originally renamed due to a misunderstanding of muted tests (which caused it to be muted again! Busted 😅).
elasticsearchmachine pushed a commit that referenced this issue Mar 6, 2025
@GalLalouche
ESQL: Fix ShapeGeometryFieldMapperTests (and rename) (#122871) (#124253)
f393fbe 
Fixes #122661.
The issue was caused by RandomIndexWriter (randomly) reshuffling the document writing order. Since this test also ensures that the documents are read in the input order, I've opted to use a regular IndexWriter instead. I've also renamed the class to AbstractShapeGeometryFieldMapperTests since it was originally renamed due to a misunderstanding of muted tests (which caused it to be muted again! Busted 😅).
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this issue Mar 11, 2025
@GalLalouche @georgewallace
ESQL: Fix ShapeGeometryFieldMapperTests (and rename) (elastic#122871)
0a71c40 
Fixes elastic#122661.
The issue was caused by RandomIndexWriter (randomly) reshuffling the document writing order. Since this test also ensures that the documents are read in the input order, I've opted to use a regular IndexWriter instead. I've also renamed the class to AbstractShapeGeometryFieldMapperTests since it was originally renamed due to a misunderstanding of muted tests (which caused it to be muted again! Busted 😅).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GalLalouche GalLalouche

Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESQL: Fix ShapeGeometryFieldMapperTests (and rename) GalLalouche/elasticsearch
2 participants
@GalLalouche @elasticsearchmachine