Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] TransportServiceHandshakeTests testAcceptsMismatchedServerlessBuildHash failing #122565

Closed
elasticsearchmachine opened this issue Feb 14, 2025 · 4 comments · Fixed by #122570
Assignees
Labels
:Distributed Coordination/Network Http and internode communication implementations low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Coordination Meta label for Distributed Coordination team >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 14, 2025

Build Scans:

Reproduction Line:

./gradlew ":server:test" --tests "org.elasticsearch.transport.TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash" -Dtests.seed=B13DEB236424409 -Dtests.jvm.argline="-Des.entitlements.enabled=false" -Dtests.locale=yo-NG -Dtests.timezone=Europe/Jersey -Druntime.java=24

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: safeGet: listener was completed exceptionally

Issue Reasons:

  • [main] 6 consecutive failures in test testAcceptsMismatchedServerlessBuildHash
  • [main] 19 consecutive failures in step openjdk24_entitlements_false_checkpart1_java-matrix
  • [main] 17 consecutive failures in step openjdk24_entitlements_true_checkpart1_java-matrix
  • [main] 2 consecutive failures in step openjdk24_checkpart1_java-matrix
  • [main] 21 consecutive failures in pipeline elasticsearch-periodic
  • [main] 38 failures in test testAcceptsMismatchedServerlessBuildHash (92.7% fail rate in 41 executions)
  • [main] 19 failures in step openjdk24_entitlements_false_checkpart1_java-matrix (100.0% fail rate in 19 executions)
  • [main] 17 failures in step openjdk24_entitlements_true_checkpart1_java-matrix (100.0% fail rate in 17 executions)
  • [main] 2 failures in step openjdk24_checkpart1_java-matrix (100.0% fail rate in 2 executions)
  • [main] 21 failures in pipeline elasticsearch-periodic (100.0% fail rate in 21 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.

@elasticsearchmachine elasticsearchmachine added :Distributed Coordination/Network Http and internode communication implementations >test-failure Triaged test failures from CI needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Distributed Coordination Meta label for Distributed Coordination team labels Feb 14, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@ywangd ywangd self-assigned this Feb 14, 2025
@ywangd ywangd added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Feb 14, 2025
@ywangd
Copy link
Member

ywangd commented Feb 14, 2025

OK. #122332 is meant to fix this. But it did not work because when the system property is set in the test, it is already too late because the static feature flag is already initialized with the false value if there are other tests running before it. There is no pretty way to make this work reliably other than breaking it into its own test job similar to this.

ywangd added a commit to ywangd/elasticsearch that referenced this issue Feb 14, 2025
This PR moves TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash
to its own test job to ensure the expected system property is always
set correctly.

Resolves: elastic#122565
@mhl-b
Copy link
Contributor

mhl-b commented Feb 14, 2025

:(

Does this test belong here? Should it be in the serverless repo?

@ywangd
Copy link
Member

ywangd commented Feb 17, 2025

Good question. I think we can look into moving this across as the next step. For the time being, can I get review on #122570 which should fix this as is? Thanks!

elasticsearchmachine pushed a commit that referenced this issue Feb 17, 2025
This PR moves
TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash
to its own test job to ensure the expected system property is always set
correctly.

Resolves: #122565
mosche pushed a commit to mosche/elasticsearch that referenced this issue Feb 26, 2025
)

This PR moves
TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash
to its own test job to ensure the expected system property is always set
correctly.

Resolves: elastic#122565
(cherry picked from commit 2eb0d00)
mosche pushed a commit to mosche/elasticsearch that referenced this issue Feb 26, 2025
)

This PR moves
TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash
to its own test job to ensure the expected system property is always set
correctly.

Resolves: elastic#122565
(cherry picked from commit 2eb0d00)
mosche pushed a commit to mosche/elasticsearch that referenced this issue Feb 26, 2025
)

This PR moves
TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash
to its own test job to ensure the expected system property is always set
correctly.

Resolves: elastic#122565
(cherry picked from commit 2eb0d00)
elasticsearchmachine pushed a commit that referenced this issue Feb 26, 2025
…123486)

This PR moves
TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash
to its own test job to ensure the expected system property is always set
correctly.

Resolves: #122565
(cherry picked from commit 2eb0d00)

Co-authored-by: Yang Wang <yang.wang@elastic.co>
elasticsearchmachine pushed a commit that referenced this issue Feb 26, 2025
…123487)

This PR moves
TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash
to its own test job to ensure the expected system property is always set
correctly.

Resolves: #122565
(cherry picked from commit 2eb0d00)

Co-authored-by: Yang Wang <yang.wang@elastic.co>
elasticsearchmachine pushed a commit that referenced this issue Feb 26, 2025
…123485)

This PR moves
TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash
to its own test job to ensure the expected system property is always set
correctly.

Resolves: #122565
(cherry picked from commit 2eb0d00)

Co-authored-by: Yang Wang <yang.wang@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Network Http and internode communication implementations low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Coordination Meta label for Distributed Coordination team >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants