-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] TransportServiceHandshakeTests testAcceptsMismatchedServerlessBuildHash failing #122565
Comments
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
OK. #122332 is meant to fix this. But it did not work because when the system property is set in the test, it is already too late because the static feature flag is already initialized with the |
This PR moves TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash to its own test job to ensure the expected system property is always set correctly. Resolves: elastic#122565
:( Does this test belong here? Should it be in the serverless repo? |
Good question. I think we can look into moving this across as the next step. For the time being, can I get review on #122570 which should fix this as is? Thanks! |
This PR moves TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash to its own test job to ensure the expected system property is always set correctly. Resolves: #122565
) This PR moves TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash to its own test job to ensure the expected system property is always set correctly. Resolves: elastic#122565 (cherry picked from commit 2eb0d00)
) This PR moves TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash to its own test job to ensure the expected system property is always set correctly. Resolves: elastic#122565 (cherry picked from commit 2eb0d00)
) This PR moves TransportServiceHandshakeTests.testAcceptsMismatchedServerlessBuildHash to its own test job to ensure the expected system property is always set correctly. Resolves: elastic#122565 (cherry picked from commit 2eb0d00)
Build Scans:
Reproduction Line:
Applicable branches:
main
Reproduces locally?:
N/A
Failure History:
See dashboard
Failure Message:
Issue Reasons:
Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
The text was updated successfully, but these errors were encountered: