Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security prerequisites support #717

Merged
merged 5 commits into from
Sep 16, 2021
Merged

Add security prerequisites support #717

merged 5 commits into from
Sep 16, 2021

Conversation

delvedor
Copy link
Member

As titled.

Closes: #713.

Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl
Copy link
Contributor

lcawl commented Sep 10, 2021

In machine learning APIs, we have some that involve "source" and "destination" indices, with different index privileges for each. For example: https://www.elastic.co/guide/en/elasticsearch/reference/current/put-dfanalytics.html, https://www.elastic.co/guide/en/elasticsearch/reference/current/put-transform.html. It looks like CCR also has different index privileges required for the "leader" and "follower" indices e.g. https://www.elastic.co/guide/en/elasticsearch/reference/current/ccr-put-follow.html Would it be possible to accommodate that here?

@delvedor
Copy link
Member Author

@lcawl I would say that this should be done via the description, since it's an edge case, and the edge case differs based on the API, I would write all the prerequisites in the tag (both source/destination and leader/follower) and add a note about it in the API description.

@lcawl
Copy link
Contributor

lcawl commented Sep 15, 2021

That seems reasonable, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API security prerequisites
3 participants