Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shutdown get node API #634

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Fix shutdown get node API #634

merged 2 commits into from
Sep 2, 2021

Conversation

stevejgordon
Copy link
Contributor

  • Updates NodeIds to be a union of string and string[] to align with other types.
  • Updates Shutdown Get Node to use NodeIds rather than NodeId[] for the path part.

philkra
philkra suggested changes Sep 1, 2021
View reviewed changes
@stevejgordon stevejgordon requested a review from philkra September 2, 2021 07:01
delvedor
delvedor approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think we should get rid of NodeId and NodeIds and just use Id and Ids.

@stevejgordon stevejgordon merged commit f26678e into main Sep 2, 2021
@stevejgordon stevejgordon deleted the fix/shutdown-get-node branch September 2, 2021 07:17
github-actions bot pushed a commit that referenced this pull request Sep 2, 2021
@stevejgordon @github-actions
Fix shutdown get node API (#634)
42376c7 
* Fix shutdown get node API

* Review feedback, using NodeId instead of string
@github-actions github-actions bot mentioned this pull request Sep 2, 2021
Merged
stevejgordon added a commit that referenced this pull request Sep 2, 2021
@github-actions @stevejgordon
Fix shutdown get node API (#634) (#643)
349eac2 
* Fix shutdown get node API

* Review feedback, using NodeId instead of string

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

@philkra philkra Awaiting requested review from philkra

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevejgordon @delvedor @philkra