Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorg ML #460

Merged
merged 10 commits into from
May 11, 2021
Merged

Reorg ML #460

merged 10 commits into from
May 11, 2021

Conversation

philkra
Copy link
Contributor

@philkra philkra commented May 10, 2021

rel: #409

@philkra philkra requested a review from a team May 11, 2021 06:53
@philkra philkra changed the title [DRAFT] Reorg ML Reorg ML May 11, 2021
@philkra philkra marked this pull request as ready for review May 11, 2021 06:53
delvedor
delvedor previously approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

There is an error in the compiler tho, it should be fixed before merging 🤔

@delvedor
Copy link
Member

Not sure why is failing, on my machine I'm not able to reproduce the error, still investigating...

@delvedor
Copy link
Member

I can't why CI is failing here, but it works on my machine as well as @swallez and @philkra. Let's merge it as is and come back later if the issue persist.

@delvedor delvedor merged commit fb16a4d into master May 11, 2021
@delvedor delvedor deleted the philkra/409-ml branch May 11, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor left review comments

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philkra @delvedor