Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorg Watcher #416

Merged
merged 16 commits into from
May 4, 2021
Merged

Reorg Watcher #416

merged 16 commits into from
May 4, 2021

Conversation

philkra
Copy link
Contributor

@philkra philkra commented May 3, 2021

ref: #409

delvedor
delvedor reviewed May 3, 2021
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move most of the nested definitions that are not requests or responses inside watcher/_types.

delvedor
delvedor previously approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the conflicts are resolved

@philkra philkra requested a review from delvedor May 4, 2021 13:43
@philkra
Copy link
Contributor Author

philkra commented May 4, 2021

@delvedor - conflicts resolved

@philkra
Copy link
Contributor Author

philkra commented May 4, 2021

conflicts resolved the 2nd 😄

@delvedor delvedor merged commit 630973a into master May 4, 2021
@delvedor delvedor deleted the watcher branch May 4, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philkra @delvedor