Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop reporting missing endpoints as errors #4031

Merged
merged 1 commit into from
Mar 24, 2025
+2 −65
Merged

Stop reporting missing endpoints as errors #4031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions compiler/src/steps/validate-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,14 +215,7 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
return
}

if (endpoint.request == null) {
if (endpoint.response == null) {
modelError('Missing request & response')
return
} else {
modelError('Missing request')
}
} else {
if (endpoint.request !== null) {
const reqType = getTypeDef(endpoint.request)

if (reqType == null) {
Expand Down Expand Up @@ -266,9 +259,7 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma

setRootContext(endpoint.name, 'response')

if (endpoint.response == null) {
modelError('Missing response')
} else {
if (endpoint.response !== null) {
const respType = getTypeDef(endpoint.response)

if (respType == null) {
Expand Down
54 changes: 0 additions & 54 deletions output/schema/validation-errors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@
],
"response": []
},
"capabilities": {
"request": [
"Missing request & response"
],
"response": []
},
"cluster.get_component_template": {
"request": [
"Request: query parameter 'flat_settings' does not exist in the json spec"
Expand All @@ -24,30 +18,6 @@
],
"response": []
},
"connector.secret_delete": {
"request": [
"Missing request & response"
],
"response": []
},
"connector.secret_get": {
"request": [
"Missing request & response"
],
"response": []
},
"connector.secret_post": {
"request": [
"Missing request & response"
],
"response": []
},
"connector.secret_put": {
"request": [
"Missing request & response"
],
"response": []
},
"create": {
"request": [
"Request: query parameter 'if_primary_term' does not exist in the json spec",
Expand All @@ -74,24 +44,6 @@
],
"response": []
},
"fleet.delete_secret": {
"request": [
"Missing request & response"
],
"response": []
},
"fleet.get_secret": {
"request": [
"Missing request & response"
],
"response": []
},
"fleet.post_secret": {
"request": [
"Missing request & response"
],
"response": []
},
"get_source": {
"request": [
"Request: query parameter 'stored_fields' does not exist in the json spec"
Expand Down Expand Up @@ -248,12 +200,6 @@
],
"response": []
},
"transform.get_node_stats": {
"request": [
"Missing request & response"
],
"response": []
},
"transform.get_transform": {
"request": [],
"response": [
Expand Down
Loading