Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit codegen_name for response value bodies #3953

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Conversation

flobernd
Copy link
Member

As titled.

The @codegen_name tag for response value bodies was not correctly emitted to the schema.json before.

I took the corresponding code (including the assertion) from the request counterpart. It's debatable wether this should be a hard error or just a validation warning. The assertion is disabled for now, until all places with missing response value body tags are fixed.

@pquentin pquentin merged commit 331583c into main Mar 18, 2025
10 checks passed
@pquentin pquentin deleted the reqponse-valuebody-codegen branch March 18, 2025 07:11
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3953-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 331583c54ed24eb2a33f853eec97776e4fdb1590
# Push it to GitHub
git push --set-upstream origin backport-3953-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3953-to-8.x.

Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-3953-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 331583c54ed24eb2a33f853eec97776e4fdb1590
# Push it to GitHub
git push --set-upstream origin backport-3953-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-3953-to-8.18.

github-actions bot pushed a commit that referenced this pull request Mar 18, 2025
* Emit `codegen_name` for response value bodies

* Run make contrib

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 331583c)
pquentin pushed a commit that referenced this pull request Mar 18, 2025
* Emit `codegen_name` for response value bodies

* Run make contrib

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 331583c)

# Conflicts:
#	output/schema/schema-serverless.json
pquentin pushed a commit that referenced this pull request Mar 18, 2025
* Emit `codegen_name` for response value bodies

* Run make contrib

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 331583c)

# Conflicts:
#	output/schema/schema-serverless.json
@pquentin
Copy link
Member

💚 All backports created successfully

Status Branch Result
8.x
8.18

Questions ?

Please refer to the Backport tool documentation

pquentin pushed a commit that referenced this pull request Mar 18, 2025
* Emit `codegen_name` for response value bodies

* Run make contrib

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 331583c)

Co-authored-by: Florian Bernd <git@flobernd.de>
pquentin added a commit that referenced this pull request Mar 18, 2025
* Emit `codegen_name` for response value bodies

* Run make contrib

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 331583c)

# Conflicts:
#	output/schema/schema-serverless.json

Co-authored-by: Florian Bernd <git@flobernd.de>
pquentin added a commit that referenced this pull request Mar 18, 2025
* Emit `codegen_name` for response value bodies

* Run make contrib

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 331583c)

# Conflicts:
#	output/schema/schema-serverless.json

Co-authored-by: Florian Bernd <git@flobernd.de>
pquentin added a commit that referenced this pull request Mar 20, 2025
pquentin added a commit that referenced this pull request Mar 20, 2025
pquentin added a commit that referenced this pull request Mar 20, 2025
pquentin added a commit that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants