Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connector API examples #3428

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Add connector API examples #3428

merged 5 commits into from
Jan 7, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 3, 2025

Relates to #2482

This PR adds the connector API example files.
It does not add overlays to hook these examples into the OpenAPI documents. That task will occur after all the examples are ported to avoid merge conflicts.

@lcawl lcawl mentioned this pull request Jan 3, 2025
Closed
65 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
connector.last_sync 🟢 7/7 7/7
connector.put 🟢 17/17 17/17
connector.sync_job_error 🟢 1/1 1/1
connector.sync_job_post 🟢 50/50 50/50
connector.update_api_key_id 🟢 4/4 4/4
connector.update_configuration 🟢 8/8 8/8
connector.update_error 🟢 4/4 4/4
connector.update_features 🟢 4/4 4/4
connector.update_filtering 🟢 12/12 12/12
connector.update_index_name 🟢 5/5 5/5
connector.update_name 🟢 4/4 4/4
connector.update_pipeline 🟢 3/3 3/3
connector.update_scheduling 🟢 3/3 3/3
connector.update_service_type 🟢 2/2 2/2
connector.update_status 🟢 3/3 3/3

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl requested a review from a team January 3, 2025 19:32
@lcawl lcawl marked this pull request as ready for review January 3, 2025 19:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
connector.last_sync 🟢 7/7 7/7
connector.put 🟢 17/17 17/17
connector.sync_job_error 🟢 1/1 1/1
connector.sync_job_post 🟢 50/50 50/50
connector.update_api_key_id 🟢 4/4 4/4
connector.update_configuration 🟢 8/8 8/8
connector.update_error 🟢 4/4 4/4
connector.update_features 🟢 4/4 4/4
connector.update_filtering 🟢 12/12 12/12
connector.update_index_name 🟢 5/5 5/5
connector.update_name 🟢 4/4 4/4
connector.update_pipeline 🟢 3/3 3/3
connector.update_scheduling 🟢 3/3 3/3
connector.update_service_type 🟢 2/2 2/2
connector.update_status 🟢 3/3 3/3

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as draft January 3, 2025 19:33
@lcawl lcawl marked this pull request as ready for review January 3, 2025 20:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
connector.check_in 🟢 3/3 3/3
connector.delete 🟢 9/9 9/9
connector.last_sync 🟢 7/7 7/7
connector.put 🟢 17/17 17/17
connector.sync_job_delete 🟢 4/4 4/4
connector.sync_job_error 🟢 1/1 1/1
connector.sync_job_post 🟢 50/50 50/50
connector.update_api_key_id 🟢 4/4 4/4
connector.update_configuration 🟢 8/8 8/8
connector.update_error 🟢 4/4 4/4
connector.update_features 🟢 4/4 4/4
connector.update_filtering 🟢 12/12 12/12
connector.update_index_name 🟢 5/5 5/5
connector.update_name 🟢 4/4 4/4
connector.update_pipeline 🟢 3/3 3/3
connector.update_scheduling 🟢 3/3 3/3
connector.update_service_type 🟢 2/2 2/2
connector.update_status 🟢 3/3 3/3

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as draft January 4, 2025 09:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
connector.check_in 🟢 3/3 3/3
connector.delete 🟢 9/9 9/9
connector.last_sync 🟢 7/7 7/7
connector.put 🟢 17/17 17/17
connector.sync_job_delete 🟢 4/4 4/4
connector.sync_job_error 🟢 1/1 1/1
connector.sync_job_post 🟢 50/50 50/50
connector.update_api_key_id 🟢 4/4 4/4
connector.update_configuration 🟢 8/8 8/8
connector.update_error 🟢 4/4 4/4
connector.update_features 🟢 4/4 4/4
connector.update_filtering 🟢 12/12 12/12
connector.update_index_name 🟢 5/5 5/5
connector.update_name 🟢 4/4 4/4
connector.update_pipeline 🟢 3/3 3/3
connector.update_scheduling 🟢 3/3 3/3
connector.update_service_type 🟢 2/2 2/2
connector.update_status 🟢 3/3 3/3

You can validate these APIs yourself by using the make validate target.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
connector.check_in 🟢 3/3 3/3
connector.delete 🟢 9/9 9/9
connector.last_sync 🟢 7/7 7/7
connector.put 🟢 17/17 17/17
connector.sync_job_delete 🟢 4/4 4/4
connector.sync_job_error 🟢 1/1 1/1
connector.sync_job_post 🟢 50/50 50/50
connector.update_api_key_id 🟢 4/4 4/4
connector.update_configuration 🟢 8/8 8/8
connector.update_error 🟢 4/4 4/4
connector.update_features 🟢 4/4 4/4
connector.update_filtering 🟢 12/12 12/12
connector.update_index_name 🟢 5/5 5/5
connector.update_name 🟢 4/4 4/4
connector.update_pipeline 🟢 3/3 3/3
connector.update_scheduling 🟢 3/3 3/3
connector.update_service_type 🟢 2/2 2/2
connector.update_status 🟢 3/3 3/3

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review January 6, 2025 16:48
@lcawl lcawl merged commit ec9e440 into main Jan 7, 2025
9 checks passed
@lcawl lcawl deleted the connector-examples branch January 7, 2025 04:20
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
@lcawl @github-actions
Add connector API examples (#3428)
8bf4393 
(cherry picked from commit ec9e440)
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
@lcawl @github-actions
Add connector API examples (#3428)
d113966 
(cherry picked from commit ec9e440)
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Merged
lcawl added a commit that referenced this pull request Jan 7, 2025
@github-actions @lcawl
Add connector API examples (#3428) (#3440)
5552a8b 
(cherry picked from commit ec9e440)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Jan 7, 2025
@github-actions @lcawl
Add connector API examples (#3428) (#3441)
deacd3e 
(cherry picked from commit ec9e440)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgewallace georgewallace georgewallace approved these changes

Assignees
No one assigned
Labels
backport 8.x backport 8.17 documentation specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcawl @georgewallace