Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output x-state instead of x-technical-preview and x-available-since #2989

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 7, 2024

Relates to #2714, #2609

Rather than implementing x-technical-preview and x-available-since, Bump.sh is going to use x-state. This PR updates the openAPI generator to reflect that change.

@lcawl lcawl marked this pull request as ready for review October 7, 2024 19:55
@lcawl lcawl requested a review from a team as a code owner October 7, 2024 19:55
@lcawl lcawl changed the title Output x-state instead of x-technical-preview Output x-state instead of x-technical-preview and x-available-since Oct 7, 2024
Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit dbde402 into main Oct 8, 2024
7 checks passed
@lcawl lcawl deleted the x-state branch October 8, 2024 14:18
Copy link
Contributor

github-actions bot commented Oct 8, 2024

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-2989-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dbde402095f807085e15699f7c0ae608ff96a887
# Push it to GitHub
git push --set-upstream origin backport-2989-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-2989-to-8.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants