Fix make validate generation #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
(cherry picked from commit 7b0984c)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
(cherry picked from commit 7b0984c)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
(cherry picked from commit 7b0984c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix,
make validatedoes not take into account specification changes as it was generating them in the wrong directory. (You can check that this is the correct directory in the Makefile.) This is also why we had to add output/schema/schema to the .gitignore file.