Skip to content

Base types should not be never #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

Anaethelion
Copy link
Contributor

types.ts in output wrongly flags empty Base types as [key:string]: never while they should really be {}.

@Anaethelion Anaethelion requested a review from a team June 12, 2024 14:46
@Anaethelion Anaethelion marked this pull request as ready for review June 13, 2024 09:08
@Anaethelion Anaethelion merged commit 289be00 into main Jun 13, 2024
6 checks passed
@Anaethelion Anaethelion deleted the base_types_should_not_be_never branch June 13, 2024 09:11
Copy link
Contributor

The backport to 8.13 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.13 8.13
# Navigate to the new working tree
cd .worktrees/backport-8.13
# Create a new branch
git switch --create backport-2612-to-8.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 289be00fed14456d30512e35b60f17857bcfd93c
# Push it to GitHub
git push --set-upstream origin backport-2612-to-8.13
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.13

Then, create a pull request where the base branch is 8.13 and the compare/head branch is backport-2612-to-8.13.

github-actions bot pushed a commit that referenced this pull request Jun 13, 2024
* Base types should be extensible and equals to {} if empty

* add revamped types.ts to output folder

* linter fix

(cherry picked from commit 289be00)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants