Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup/improve compiler rs #2382

Merged
merged 8 commits into from
Jan 12, 2024
Merged

Cleanup/improve compiler rs #2382

merged 8 commits into from
Jan 12, 2024

Conversation

swallez
Copy link
Member

@swallez swallez commented Jan 11, 2024

This PR improves the code in compiler-rs:

  • the first commit introduces derive_more to automatically derive From for enums member values
  • 2nd commit significantly reduces (by 1MB) the size of the .wasm file by not using regex
  • subsequent commits are mechanical with rustfmt and clippy

@swallez swallez requested a review from Anaethelion January 11, 2024 14:58
@swallez swallez self-assigned this Jan 11, 2024
@swallez swallez requested a review from a team as a code owner January 11, 2024 14:58
@Anaethelion Anaethelion self-requested a review January 12, 2024 14:54
Anaethelion
Anaethelion approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swallez swallez merged commit cf1b47a into elastic:main Jan 12, 2024
@swallez swallez deleted the enhance-compiler-rs branch January 12, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anaethelion Anaethelion Anaethelion approved these changes

Assignees

@swallez swallez

Labels
compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swallez @Anaethelion