Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enrich policy query should be a QueryContainer #2347

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Enrich policy query should be a QueryContainer #2347

merged 3 commits into from
Dec 14, 2023

Conversation

JoshMock
Copy link
Member

JoshMock and others added 2 commits December 13, 2023 12:04
@JoshMock @Anaethelion
Update specification/enrich/_types/Policy.ts
c97ebbb 
Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co>
@JoshMock
Merge branch 'main' into enrich-policy-query
a0c1ca9
@JoshMock JoshMock marked this pull request as ready for review December 13, 2023 18:05
@JoshMock JoshMock requested a review from Anaethelion December 13, 2023 18:05
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
enrich.delete_policy 🟢 5/5 5/5
enrich.execute_policy 🟢 6/6 6/6
enrich.get_policy 🟢 6/6 6/6
enrich.put_policy 🟢 6/6 6/6
enrich.stats 🟢 5/5 5/5

You can validate these APIs yourself by using the make validate target.

Anaethelion
Anaethelion approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoshMock JoshMock merged commit 85c0494 into main Dec 14, 2023
@JoshMock JoshMock deleted the enrich-policy-query branch December 14, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker left review comments

@Anaethelion Anaethelion Anaethelion approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshMock @simianhacker @Anaethelion