Update QueryRulesetPutRequest body to better align with REST API #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
saikatsarkar056
approved these changes
Sep 14, 2023
carlosdelest
approved these changes
Sep 14, 2023
pquentin
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Thanks! LGTM. I confirmed with @Anaethelion that the Python client should probably not be affected by the change here, but is in practice, so let's merge this to unblock you.
pquentin
pushed a commit
that referenced
this pull request
Sep 20, 2023
…) (#2287) Co-authored-by: Kathleen DeRusso <kathleen.derusso@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix. See elastic/elasticsearch-py#2299