Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Descriptions for SQL APIs #2264

Merged
merged 3 commits into from
Sep 4, 2023
Merged

[DOCS] Descriptions for SQL APIs #2264

merged 3 commits into from
Sep 4, 2023

Conversation

abdonpijpelink
Copy link
Contributor

Relates to #964.

Adds descriptions for SQL APIs. Descriptions were sourced from https://www.elastic.co/guide/en/elasticsearch/reference/current/sql-apis.html

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, otherwise LGTM!

abdonpijpelink and others added 2 commits September 4, 2023 13:27
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Following you can find the validation results for the APIs you have changed.

API Status Request Response
sql.clear_cursor 🟢 1/1 1/1
sql.delete_async Missing test Missing test
sql.get_async_status Missing test Missing test
sql.get_async Missing test Missing test
sql.query 🟢 5/5 5/5
sql.translate 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@abdonpijpelink abdonpijpelink merged commit bdbf779 into main Sep 4, 2023
@abdonpijpelink abdonpijpelink deleted the sql-descriptions branch September 4, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants