Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in aggregations found with java-client+recordings #1940

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

swallez
Copy link
Member

@swallez swallez commented Oct 5, 2022

Fixes aggregation issues found loading test recordings with the Java client.

Fixes #1879

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, had one question but otherwise this is good to merge. Nice work! Getting so close to 100% on the Search API 🚀

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 1545/1583 1557/1565

You can validate this API yourself by using the make validate target.

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java-client+recordings validation errors - Aggregations
2 participants