-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[validation-errors] Fixes in watcher API #1889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, here's a handful of comments:
This comment was marked as resolved.
This comment was marked as resolved.
I've resolved my comment on structure, thanks for the explanation on how this is different from a container variant. Will approve once other changes are in |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1889-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 d8b3a91ea0f5d71a383cae53ad66ee64f3aa262e
# Push it to GitHub
git push --set-upstream origin backport-1889-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17 Then, create a pull request where the |
* Adding cancelled properties as optional since is hides behind a `include_cancelled` param. * Add UDF as a possible value for FieldValue * changing input into a singlekey dictionnary to capture nesting * Fixing compare & array_compare conditions * Add codegen name for udf * Fix inversion during refactoring * Add refreshed schema & types * Prettifying code * Rename udf in favor of any * Remove unused imports * Update schema
* Adding cancelled properties as optional since is hides behind a `include_cancelled` param. * Add UDF as a possible value for FieldValue * changing input into a singlekey dictionnary to capture nesting * Fixing compare & array_compare conditions * Add codegen name for udf * Fix inversion during refactoring * Add refreshed schema & types * Prettifying code * Rename udf in favor of any * Remove unused imports * Update schema Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1889-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 d8b3a91ea0f5d71a383cae53ad66ee64f3aa262e
# Push it to GitHub
git push --set-upstream origin backport-1889-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17 Then, create a pull request where the |
* Adding cancelled properties as optional since is hides behind a `include_cancelled` param. * Add UDF as a possible value for FieldValue * changing input into a singlekey dictionnary to capture nesting * Fixing compare & array_compare conditions * Add codegen name for udf * Fix inversion during refactoring * Add refreshed schema & types * Prettifying code * Rename udf in favor of any * Remove unused imports * Update schema
* Adding cancelled properties as optional since is hides behind a `include_cancelled` param. * Add UDF as a possible value for FieldValue * changing input into a singlekey dictionnary to capture nesting * Fixing compare & array_compare conditions * Add codegen name for udf * Fix inversion during refactoring * Add refreshed schema & types * Prettifying code * Rename udf in favor of any * Remove unused imports * Update schema
TaskInfo
.UserDefinedValue
inFieldValue
union.Fixes #1886