Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[validation-errors] Fixes in watcher API #1889

Merged
merged 11 commits into from
Sep 23, 2022
Merged

[validation-errors] Fixes in watcher API #1889

merged 11 commits into from
Sep 23, 2022

Conversation

Anaethelion
Copy link
Contributor

  • Add a cancelled property to TaskInfo.
  • Add UserDefinedValue in FieldValue union.
  • Fix watcher input and conditions.

Fixes #1886

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, here's a handful of comments:

@sethmlarson

This comment was marked as resolved.

@sethmlarson
Copy link
Contributor

I've resolved my comment on structure, thanks for the explanation on how this is different from a container variant. Will approve once other changes are in :shipit:

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
tasks.cancel 🟢 2/2 2/2
tasks.get 🟢 10/10 10/10
tasks.list 🟢 9/9 9/9
watcher.ack_watch 🟢 1/1 1/1
watcher.activate_watch 🟢 1/1 1/1
watcher.deactivate_watch 🟢 1/1 1/1
watcher.delete_watch 🟢 2/2 2/2
watcher.execute_watch 🟢 7/7 7/7
watcher.get_watch 🟢 9/9 9/9
watcher.put_watch 🔴 29/38 38/38
watcher.query_watches Missing test Missing test
watcher.start 🟢 1/1 1/1
watcher.stats 🟢 1/1 1/1
watcher.stop 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anaethelion Anaethelion merged commit d8b3a91 into main Sep 23, 2022
@Anaethelion Anaethelion deleted the lsf/1886 branch September 23, 2022 15:52
@github-actions
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1889-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 d8b3a91ea0f5d71a383cae53ad66ee64f3aa262e
# Push it to GitHub
git push --set-upstream origin backport-1889-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-1889-to-7.17.

github-actions bot pushed a commit that referenced this pull request Sep 23, 2022
* Adding cancelled properties as optional since is hides behind a `include_cancelled` param.

* Add UDF as a possible value for FieldValue

* changing input into a singlekey dictionnary to capture nesting

* Fixing compare & array_compare conditions

* Add codegen name for udf

* Fix inversion during refactoring

* Add refreshed schema & types

* Prettifying code

* Rename udf in favor of any

* Remove unused imports

* Update schema
Anaethelion added a commit that referenced this pull request Sep 23, 2022
* Adding cancelled properties as optional since is hides behind a `include_cancelled` param.

* Add UDF as a possible value for FieldValue

* changing input into a singlekey dictionnary to capture nesting

* Fixing compare & array_compare conditions

* Add codegen name for udf

* Fix inversion during refactoring

* Add refreshed schema & types

* Prettifying code

* Rename udf in favor of any

* Remove unused imports

* Update schema

Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co>
@github-actions
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1889-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 d8b3a91ea0f5d71a383cae53ad66ee64f3aa262e
# Push it to GitHub
git push --set-upstream origin backport-1889-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-1889-to-7.17.

Anaethelion added a commit that referenced this pull request Sep 23, 2022
* Adding cancelled properties as optional since is hides behind a `include_cancelled` param.

* Add UDF as a possible value for FieldValue

* changing input into a singlekey dictionnary to capture nesting

* Fixing compare & array_compare conditions

* Add codegen name for udf

* Fix inversion during refactoring

* Add refreshed schema & types

* Prettifying code

* Rename udf in favor of any

* Remove unused imports

* Update schema
Anaethelion added a commit that referenced this pull request Sep 27, 2022
* Adding cancelled properties as optional since is hides behind a `include_cancelled` param.

* Add UDF as a possible value for FieldValue

* changing input into a singlekey dictionnary to capture nesting

* Fixing compare & array_compare conditions

* Add codegen name for udf

* Fix inversion during refactoring

* Add refreshed schema & types

* Prettifying code

* Rename udf in favor of any

* Remove unused imports

* Update schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java-client+recordings validation errors - Tasks & Watcher
3 participants