Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watcher.execute_watch #1456

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Fix watcher.execute_watch #1456

merged 1 commit into from
Feb 15, 2022

Conversation

philkra
Copy link
Contributor

@philkra philkra commented Feb 11, 2022

as titled.

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
watcher.ack_watch 🟢 1/1 1/1
watcher.activate_watch 🟢 1/1 1/1
watcher.deactivate_watch 🟢 1/1 1/1
watcher.delete_watch 🟢 2/2 2/2
watcher.execute_watch 🟢 7/7 7/7
watcher.get_watch 🟢 9/9 9/9
watcher.put_watch 🔴 29/38 38/38
watcher.query_watches Missing test Missing test
watcher.start 🟢 1/1 1/1
watcher.stats 🟢 1/1 1/1
watcher.stop 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@philkra philkra merged commit 91e0871 into main Feb 15, 2022
@philkra philkra deleted the watcher.execute_watch branch February 15, 2022 12:01
github-actions bot pushed a commit that referenced this pull request Feb 15, 2022
@github-actions
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1456-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 91e08714774302a2056a7003754c218117484ac2
# Push it to GitHub
git push --set-upstream origin backport-1456-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-1456-to-7.17.

github-actions bot pushed a commit that referenced this pull request Feb 15, 2022
philkra added a commit that referenced this pull request Feb 15, 2022
Co-authored-by: Philip Krauss <35487337+philkra@users.noreply.github.com>
philkra added a commit that referenced this pull request Feb 15, 2022
Co-authored-by: Philip Krauss <35487337+philkra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants