Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate both request and response at the same time #1227

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Validate both request and response at the same time #1227

merged 1 commit into from
Dec 28, 2021

Conversation

delvedor
Copy link
Member

@delvedor delvedor commented Dec 28, 2021 •
edited
Loading

If you want to validate both requests and response types at the same time, omit the type argument in the make command, for example:

# this will validate the request
make validate stack-version=8.1.0-SNAPSHOT api=indices.create type=request

# this will validate the response
make validate stack-version=8.1.0-SNAPSHOT api=indices.create type=response

# this will validate both request and response
make validate stack-version=8.1.0-SNAPSHOT api=indices.create

@delvedor delvedor merged commit 5f29691 into main Dec 28, 2021
@delvedor delvedor deleted the validate-req-and-res branch December 28, 2021 16:41
github-actions bot pushed a commit that referenced this pull request Dec 28, 2021
@delvedor @github-actions
Validate both request and response at the same time (#1227)
9a1a3cc
@github-actions github-actions bot mentioned this pull request Dec 28, 2021
Merged
delvedor added a commit that referenced this pull request Dec 28, 2021
@github-actions @delvedor
Validate both request and response at the same time (#1227) (#1228)
7d0487f 
Co-authored-by: Tomas Della Vedova <delvedor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

@philkra philkra Awaiting requested review from philkra

Assignees
No one assigned
Labels
backport 7.17 compiler documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delvedor @sethmlarson