Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix watcher.execute_watch #1183

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Fix watcher.execute_watch #1183

merged 1 commit into from
Dec 23, 2021

Conversation

philkra
Copy link
Contributor

@philkra philkra commented Dec 23, 2021

fixes the response and adds more descriptions to the request class.

@philkra philkra requested a review from a team December 23, 2021 09:28
delvedor
delvedor approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philkra philkra merged commit bc88c1d into main Dec 23, 2021
@philkra philkra deleted the transform-001 branch December 23, 2021 10:12
github-actions bot pushed a commit that referenced this pull request Dec 23, 2021
@philkra @github-actions
watcher.execute (#1183)
6bf3b80
@github-actions github-actions bot mentioned this pull request Dec 23, 2021
Merged
philkra added a commit that referenced this pull request Dec 23, 2021
@github-actions @philkra
watcher.execute (#1183) (#1188)
e301bc0 
Co-authored-by: Philip Krauss <35487337+philkra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
backport 8.0 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philkra @delvedor