Added condition for :update after commit & rescue if record NotFound #780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys
I just added readme condition for such case:
Instance of article exists, persisted, and published so successfully indexed. Then, if you make it unpublished, according to current example it will not be indexed, because
I've added condition to delete document if it's non-published, and update if published. In case document was published (created), then deleted (on update hook), and then published again,
__elasticsearch__.update_document
will create a new document.Second point is exception handling - when gem trying to delete non-existing document, it throws
Elasticsearch::Transport::Transport::Errors::NotFound
. I've just addedrescue
for it.Thank you.