Skip to content

Hashie::Mash existence methods should always delegate to @result._source #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

emptyflask
Copy link
Contributor

Before:

@result.title #=> "Example"
@result.title? #=> false
@result._source.title? #=> true

With this change:

@result.title #=> "Example"
@result.title? #=> true
@result._source.title? #=> true

@emptyflask
Copy link
Contributor Author

We might have to rethink this, if highlight? and facets? are expected to work as well.

@karmi
Copy link
Contributor

karmi commented Apr 3, 2014

Facets are on the main response object, but highlight is a valid question...

karmi pushed a commit that referenced this pull request Apr 17, 2014
karmi added a commit that referenced this pull request Apr 17, 2014
…t.foo?`) implementation and tests

Closes ##70

Related: #41, #64
@karmi
Copy link
Contributor

karmi commented Apr 17, 2014

@emptyflask Merged the commits, thanks!

@karmi
Copy link
Contributor

karmi commented Apr 17, 2014

Grr Github formatting pedantry, Closes: #64 should have been Closes #64...

@karmi karmi closed this Apr 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants