Rails 5 bundle install error #634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frontandstart, correct! Can you please sign the CLA so I can process the patch? |
|
@karmi I think, done |
|
Still can't find you in the records... I'd like to merge your patch to give you credit, but would like to have it CLA processed... Any problem if I mention you in the commit message for the overall patch for Rails compatibility and change the line myself? |
karmi
added a commit
that referenced
this pull request
Feb 11, 2017
…csearch 5 This patch adds support for both Rails 5 and Elasticsearch 5 for the application templates in `elasticsearch-rails/lib/rails/templates/`. The main problems on the Elasticsearch side have been in incorrect mapping, which still used the `multi_field` property type. The mapping definition in the `searchable.rb` and `searchable.dsl.rb` has been fixed, along with small fixes in HTML views an the `SearchController`. On the Rails side, the `quiet_assets` gem has been removed, as originally reported by @frontandstart in #634, and various fixes in the HTML views (using `params.permit`, ...) and in the controller test (using the new syntax for passing parameters) have been done. The templates are still compatible with Rails 4. Closes #655
karmi
added a commit
that referenced
this pull request
Feb 11, 2017
…csearch 5 This patch adds support for both Rails 5 and Elasticsearch 5 for the application templates in `elasticsearch-rails/lib/rails/templates/`. The main problems on the Elasticsearch side have been in incorrect mapping, which still used the `multi_field` property type. The mapping definition in the `searchable.rb` and `searchable.dsl.rb` has been fixed, along with small fixes in HTML views an the `SearchController`. On the Rails side, the `quiet_assets` gem has been removed, as originally reported by @frontandstart in #634, and various fixes in the HTML views (using `params.permit`, ...) and in the controller test (using the new syntax for passing parameters) have been done. The templates are still compatible with Rails 4. Closes #655
|
Ok, thanks. I was redirected on your website and be sure that sign you CLA in PDF. but any way thank you for mention) First commit in open source its like first sex, very exiting) |
|
I'm closing this as it appears to be in the code base already as of this commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bundle install in Rails 5
"As of sprockets-rails version 3.1.0, used in current versions of rails, this gem is deprecated." from https://github.com/evrone/quiet_assets