Skip to content

edit Asynchronous Callbacks example #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

edit Asynchronous Callbacks example #518

wants to merge 1 commit into from

Conversation

wykhuh
Copy link
Contributor

@wykhuh wykhuh commented Jan 11, 2016

Change record.as_indexed_json to record.__elasticsearch__.as_indexed_json in the Asynchronous Callbacks example.

Change `record.as_indexed_json ` to `record.__elasticsearch__.as_indexed_json` in the `Asynchronous Callbacks` example.
@karmi
Copy link
Contributor

karmi commented Jan 22, 2016

Although this makes some sense, I'd like to know why it's needed? Did you experience any error with the code? Also, can you please sign the CLA so I can merge your patches?

@karmi karmi added the waiting label Jan 22, 2016
@wykhuh
Copy link
Contributor Author

wykhuh commented Jan 23, 2016

I recently installed elasticsearch on a Rails project. I was following the sample code, and got an error. When I added __elasticsearch__, the code worked. I've signed the CLA.

@tylerjl tylerjl closed this in 0afd8b8 Apr 11, 2017
@karmi
Copy link
Contributor

karmi commented Apr 12, 2017

@wykhuh Apologies for the ridiculously long delay, it has been now processed and merged by @tylerjl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants