[MODEL] Add "suggest" method to get response suggest #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it makes sense. Can we also have integration tests for the feature, and update to the example application HTML template (in a separate commit?) |
|
Some tests on Travis are failing, do they run locally for you? |
|
I fixed it. |
karmi
pushed a commit
that referenced
this pull request
Jan 22, 2016
… the application template Related: #483
karmi
added a commit
that referenced
this pull request
Jan 22, 2016
|
I'm sorry for such a long delay, I've tweaked the code a bit and merged it! Thanks! |
karmi
added a commit
that referenced
this pull request
Jan 22, 2016
Refactored the accessor for the `suggest` part of the response introduced in #483 to allow a richer interface. Added a `terms` helper method which just returns a flat array of response.suggestions.terms # => [ 'Foo', 'Bar' ] Related: rubygems/rubygems.org#1135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to use suggest of Elasticsearch response.
But
Elasticsearch::Model::Response::Responseclass hasn't the method. That's why I added it.I have already signed the CLA.