Fix timestamp tests #407
Closed
Fix timestamp tests #407
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until we have a version of rails that uses millisecond precision (>=4.1) we have to wait an entire second to avoid race conditions.
|
@karmi Fixed the failing tests on master. Need to revert your sleep changes. |
|
Thanks, Ryan!, I guess I got carried away by the one green run when I tweaked your patch and wasn't thinking :) |
|
:-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we have a version of rails that uses millisecond precision (>=4.1)
we have to wait an entire second to avoid race conditions.
See https://github.com/elastic/elasticsearch-rails/pull/395/files#diff-beb7964b74f717683049a9437a5570a2R1 for a breakdown on the differences in timestamp precision in different versions of rails.