Do not reinvent Enumerable#each_slice #378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lompy Nice!! Can you sign the CLA so I can merge it? |
|
@karmi Sorry, I don't know what CLA means and what it means to sign it. |
|
@lompy Sorry for brevity, it's described in the contributing guidelines, the target link is https://www.elastic.co/contributor-agreement/?license=icla |
|
@karmi Signed it providing my github name, but CLA check still fails |
|
@lompy It's not auto-updating (something we might add in the future), but I can see the signature as verified now, thanks! |
|
Thanks!, merged! |
|
No proplem! Next time I'll try to read contributing guidelines |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just spotted good use case for Enumerable#each_slice