[MODEL] Fix wrong retrieval of records corresponding to indexed documents when querying multiple models #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #369
case/when
statement, as for objects.case/when
only matches the branches in which===
returns true. i.e. an object that is instance of a class. But if the object is a class itself, or a module like the adapters, it won't enter any of thewhen
branches.compact
over the collection of records, because as per eventual consistency, ES can return some results, which corresponding records no longer exist. As a consequence, calling records would return an array with positions including nil.