[PERSISTENCE] Forward document type to mappings #366
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the bug described in #270
The problem was the following.
Persistence::Model
it sets up two attributes. As a consequence, theattribute
macro instantiates aElasticsearch::Model::Indexing::Mappings
in the model. This instance contains an attribute@type
that defaults to the model name in lowercase.document_type
will override the document_type in thegateway
delegate, but themappings
instance originally created in the previous step remains untouched, and hence in an inconsistent state.What I did here is: Instead of simply forward
document_type
to the gateway, also change the mappings'document_type
accordingly, leaving it in a correct state.An integration test was modified, in order to have a regression of the fix.