modified the note about pagination gem order more clearer #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -257,7 +257,7 @@ response.records.each_with_hit { |record, hit| puts "* #{record.title}: #{hit._s | |||
| You can implement pagination with the `from` and `size` search parameters. However, search results | |||
| can be automatically paginated with the [`kaminari`](http://rubygems.org/gems/kaminari) or | |||
| [`will_paginate`](https://github.com/mislav/will_paginate) gems. | |||
| (The gems have to be added _first_ in your Gemfile, or loaded first in your application.) | |||
| (The pagination gem must be added brfore the elasticsearch gems in your Gemfile, or loaded first in your application.) | |||
There was a problem hiding this comment.
Yeah, that makes sense! Can you just correct the typo in before? :)
|
Sorry for my carelessness, I have corrected it |
|
That's ok ! I have signed the agreement and verified it. :) |
|
Thanks!, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the #309 was due to wrong gems order, people can put pagination gem before the elasticsearch gems to avoid it. Put them in the first of Gemfile is not necessary,just keep right order will be fine.